Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Bump XDR for soroban-pubnet release #5079

Merged
merged 10 commits into from
Oct 17, 2023
Merged

all: Bump XDR for soroban-pubnet release #5079

merged 10 commits into from
Oct 17, 2023

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Oct 11, 2023 •
edited
Loading

Update XDR to 6a620d160aab22609c982d54578ff6a63bfcdc01

Integration tests won't pass until soroban-rpc is updated and bumped in this repo.

@2opremio 2opremio requested a review from a team October 11, 2023 12:40
@2opremio 2opremio closed this Oct 11, 2023
@2opremio 2opremio reopened this Oct 11, 2023
@tamirms tamirms changed the base branch from master to release-horizon-v2.27.0 October 11, 2023 16:49
@tamirms
Copy link
Contributor

tamirms commented Oct 11, 2023

@2opremio I have retarted the PR to land on the pubnet release branch release-horizon-v2.27.0

@tamirms
Copy link
Contributor

tamirms commented Oct 11, 2023

@2opremio can you rebase so the pr only contains the xdr update?

@tsachiherman tsachiherman changed the title all: Bump XDR for soroban-pubnet releasre all: Bump XDR for soroban-pubnet release Oct 11, 2023
@2opremio
Copy link
Contributor Author

Sure!

@2opremio 2opremio force-pushed the bump-xdr-pubnet branch 2 times, most recently from 09fa14b to 8ee7ea0 Compare October 16, 2023 09:35
@2opremio
Bump XDR
e3bb272 
Update XDR to [`bdb81c3710ecb12f0fcc23268b211eb237500019`](https://github.com/stellar/stellar-xdr/tree/bdb81c3710ecb12f0fcc23268b211eb237500019)
@tsachiherman
Copy link
Contributor

There are quite many ST1003: method SetTtl should be SetTTL (stylecheck) -style warning coming from the linter.
( see file changed tab )

@2opremio
Copy link
Contributor Author

quite many ST1003: method SetTtl should be SetTTL (stylecheck) -style warning coming from the linter.
( see file changed tab )

Yes, I noticed. Like in other cases, I preferred to make it consistent with the XDR-generated types.

@Shaptic
Copy link
Contributor

Shaptic commented Oct 17, 2023 •
edited
Loading

@2opremio according to this thread the SHA should be stellar/stellar-xdr@6a620d1

Jk I see you did that in c7d3a47. Don't forget to update the description/merge commit message!

@2opremio
Copy link
Contributor Author

@2opremio according to this thread the SHA should be stellar/stellar-xdr@6a620d1

Jk I see you did that in c7d3a47. Don't forget to update the description/merge commit message!

Done!

@2opremio 2opremio merged commit 48d2284 into release-horizon-v2.27.0 Oct 17, 2023
36 checks passed
@2opremio 2opremio deleted the bump-xdr-pubnet branch October 17, 2023 18:20
@2opremio 2opremio mentioned this pull request Oct 24, 2023
Merged
tamirms pushed a commit to tamirms/go that referenced this pull request Dec 11, 2023
@2opremio @tamirms
all: Bump XDR for soroban-pubnet release (stellar#5079)
0292a74 
Update XDR to [`bdb81c3710ecb12f0fcc23268b211eb237500019`](https://github.com/stellar/stellar-xdr/tree/bdb81c3710ecb12f0fcc23268b211eb237500019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirms tamirms tamirms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2opremio @tamirms @tsachiherman @Shaptic